Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPS-971: Load text domain during init action to prevent early translation loading error. #1022

Closed
wants to merge 12 commits into from

Conversation

vijetaR
Copy link
Contributor

@vijetaR vijetaR commented Dec 20, 2024

Description

Getting a notice -
The _load_textdomain_just_in_time function was called incorrectly. Translation loading for the header-footer domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the init action or later. (This message was added in version 6.7.0.)

Screenshots

https://bsf.d.pr/v/XXvEap

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  1. Install Loco translate
  2. Select the language further
  3. Set the language in your setting
  4. Check for all the settings for the UAE, it should remain intact.
  5. Screencast - https://bsf.d.pr/v/XXvEap

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@sushmak02 sushmak02 closed this Dec 31, 2024
@vijetaR vijetaR deleted the text-domain-issue branch January 13, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants